[User] 유저 도메인 테스트 코드 작성 by larama-C · Pull Request #206 · prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE

larama-C · 2025-12-29T04:52:31Z

🔗 관련 이슈

관련된 이슈 번호를 연결해주세요.
Close #이슈번호 를 쓰면 PR merge 시 자동으로 close 됩니다.

Close [User] 유저 도메인 테스트 코드 작성 #195

🚀 PR 개요

이 PR이 어떤 변경을 포함하고 있는지 간단히 설명해주세요.

유저 도메인(UserService)의 핵심 비즈니스 로직에 대한 단위 테스트를 추가했습니다.

📌 변경 사항

주요 변경 내용을 체크리스트 형태로 정리해주세요.

🧪 테스트 방법

변경된 내용을 어떻게 테스트했는지 구체적으로 적어주세요.

유저 컨트롤러 테스트 로컬에서 정상 작동 확인했습니다.
유저 서비스 테스트 로컬에서 정상 작동 확인했습니다.

📸 스크린샷 (선택)

UI 변경 또는 시각적으로 확인할 수 있는 변경이 있다면 첨부해주세요.

⚠️ 참고 사항

리뷰어가 알아야 할 사항이 있다면 자유롭게 작성해주세요.

근데 테스트 커버리지가 왜 1.9퍼센트 밖에 안올랐을까요...?

github-actions · 2025-12-29T04:54:46Z

Test Results

23 tests +17 23 ✅ +17 2s ⏱️ +2s
5 suites + 2 0 💤 ± 0
5 files + 2 0 ❌ ± 0

Results for commit 7720a63. ± Comparison against base commit ddce6fe.

github-actions · 2025-12-29T04:55:03Z

⭐ JaCoCo Coverage

Line Coverage: 7.77%

📄 Coverage Details

Overall Line Coverage: 7.75% (297 covered / 3833 lines)

Package Summary (lowest first)

Package	Line %	Covered	Missed
`com/back/web7_9_codecrete_be/domain/plans/controller`	0.00%	0	49
`com/back/web7_9_codecrete_be/domain/location/controller`	0.00%	0	54
`com/back/web7_9_codecrete_be/domain/community/post/service`	0.00%	0	45
`com/back/web7_9_codecrete_be/domain/chats/entity`	0.00%	0	4
`com/back/web7_9_codecrete_be/domain/location/entity`	0.00%	0	15
`com/back/web7_9_codecrete_be/global/scheduler`	0.00%	0	11
`com/back/web7_9_codecrete_be/domain/auth/entity`	0.00%	0	0
`com/back/web7_9_codecrete_be/global/websocket`	0.00%	0	10
`com/back/web7_9_codecrete_be/domain/auth/service`	0.00%	0	135
`com/back/web7_9_codecrete_be/domain/plans/service`	0.00%	0	362
`com/back/web7_9_codecrete_be/global/initData`	0.00%	0	54
`com/back/web7_9_codecrete_be/domain/email/entity`	0.00%	0	6
`com/back/web7_9_codecrete_be/domain/community/comment/service`	0.00%	0	17
`com/back/web7_9_codecrete_be/domain/auth/controller`	0.00%	0	24
`com/back/web7_9_codecrete_be/domain/community/comment/controller`	0.00%	0	7
`com/back/web7_9_codecrete_be/domain/artists/controller`	0.00%	0	34
`com/back/web7_9_codecrete_be/domain/community/comment/entity`	0.00%	0	12
`com/back/web7_9_codecrete_be/domain/community/post/controller`	0.00%	0	20
`com/back/web7_9_codecrete_be/global/wikidata`	0.27%	1	374
`com/back/web7_9_codecrete_be/global/musicbrainz`	0.46%	1	215
`com/back/web7_9_codecrete_be/domain/artists/service`	0.54%	4	740
`com/back/web7_9_codecrete_be/domain/email/service`	1.61%	1	61
`com/back/web7_9_codecrete_be/global/flo`	1.85%	1	53
`com/back/web7_9_codecrete_be/domain/chats/service`	1.92%	1	51
`com/back/web7_9_codecrete_be/domain/concerts/controller`	2.50%	1	39
`com/back/web7_9_codecrete_be/domain/concerts/entity`	3.26%	3	89
`com/back/web7_9_codecrete_be/domain/concerts/repository`	3.45%	1	28
`com/back/web7_9_codecrete_be/global/storage`	3.57%	2	54
`com/back/web7_9_codecrete_be/domain/concerts/service`	4.78%	25	498
`com/back/web7_9_codecrete_be/domain/artists/entity`	6.45%	4	58
`com/back/web7_9_codecrete_be/global/rq`	9.80%	5	46
`com/back/web7_9_codecrete_be/domain/users/util`	14.29%	1	6
`com/back/web7_9_codecrete_be/domain/community/post/entity`	16.67%	6	30
`com/back/web7_9_codecrete_be/domain/chats/controller`	20.00%	2	8
`com/back/web7_9_codecrete_be/domain/plans/entity`	21.88%	21	75
`com/back/web7_9_codecrete_be/domain/users/service`	33.01%	34	69
`com/back/web7_9_codecrete_be/global/spotify`	35.71%	5	9
`com/back/web7_9_codecrete_be/global/security`	36.19%	38	67
`com/back/web7_9_codecrete_be/domain/location/service`	43.07%	59	78
`com/back/web7_9_codecrete_be/domain/users/controller`	61.54%	16	10
`com/back/web7_9_codecrete_be/domain/users/entity`	67.31%	35	17
`com/back/web7_9_codecrete_be/global/rsData`	81.82%	9	2
`com/back/web7_9_codecrete_be/global/doc`	100.00%	17	0
`com/back/web7_9_codecrete_be/global/aspect`	100.00%	4	0

Lowest Covered Classes (Top 20)

Class	Line %	Missed
`com.back.web7_9_codecrete_be.domain.plans.service.PlanService`	0.00%	362
`com.back.web7_9_codecrete_be.domain.artists.service.EnrichStepExecutor`	0.00%	130
`com.back.web7_9_codecrete_be.domain.artists.service.ArtistService`	0.00%	98
`com.back.web7_9_codecrete_be.domain.artists.service.WikidataEnrichHelper`	0.00%	78
`com.back.web7_9_codecrete_be.domain.auth.service.AuthService`	0.00%	73
`com.back.web7_9_codecrete_be.global.initData.BaseInitData`	0.00%	54
`com.back.web7_9_codecrete_be.domain.plans.controller.PlanController`	0.00%	49
`com.back.web7_9_codecrete_be.domain.location.controller.KakaoApiController`	0.00%	43
`com.back.web7_9_codecrete_be.domain.concerts.entity.Concert`	0.00%	42
`com.back.web7_9_codecrete_be.domain.artists.entity.Artist`	0.00%	40
`com.back.web7_9_codecrete_be.domain.plans.entity.Schedule`	0.00%	37
`com.back.web7_9_codecrete_be.global.security.JwtTokenProvider`	0.00%	37
`com.back.web7_9_codecrete_be.domain.community.post.service.PostService`	0.00%	36
`com.back.web7_9_codecrete_be.domain.location.service.LocationService`	0.00%	30
`com.back.web7_9_codecrete_be.domain.concerts.entity.ConcertPlace`	0.00%	29
`com.back.web7_9_codecrete_be.domain.chats.service.ChatPolicyService`	0.00%	27
`com.back.web7_9_codecrete_be.domain.plans.entity.Plan`	0.00%	27
`com.back.web7_9_codecrete_be.domain.artists.controller.ArtistsController`	0.00%	27
`com.back.web7_9_codecrete_be.domain.auth.service.TokenService`	0.00%	26
`com.back.web7_9_codecrete_be.domain.auth.controller.AuthController`	0.00%	24

Changed Classes (from this PR)

Source (PR)	Class Prefix	Line %	Covered	Missed
`src/main/java/com/back/web7_9_codecrete_be/domain/users/dto/request/UserUpdateNicknameRequest.java`	`com.back.web7_9_codecrete_be.domain.users.dto.request.UserUpdateNicknameRequest`	0.00%	0	0
`src/main/java/com/back/web7_9_codecrete_be/global/error/code/UserErrorCode.java`	`com.back.web7_9_codecrete_be.global.error.code.UserErrorCode`	0.00%	0	0

🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20565149304

Creamcheesepie

테스트코드 전반적으로 잘 짜신거 같습니다.

Creamcheesepie · 2025-12-29T07:45:50Z

@@ -1,13 +1,57 @@
 spring:


api관련 테스트를 전부 따로 넣으셨네요. 쓰지 않을 기능에 대해서 따로 환경변수를 넣지 않아도 되어서 편리할 것 같습니다

ys0221 · 2025-12-29T07:47:59Z

+                .andExpect(jsonPath("$.data").value("회원 탈퇴가 완료되었습니다."));
+    }
+
+    // 실패 테스트 시나리오


회원 탈퇴 실패에 대한 테스트도 있으면 좋을 것 같습니다!!

회원 실패 케이스에 대해서 고민 해보긴 했는데 마땅히 떠오르는 부분이 없어서 조금 더 고민해보겠습니다!

ys0221

고생하셨습니다!!

kms152000

고생하셨습니다~

larama-C added 4 commits December 29, 2025 13:47

feat: 테스트 코드를 위한 더미값 추가

fd29a9f

refactor: 유저 에러코드 넘버링 수정

512c3d5

refactor: DTO에 기본 생성자 및 전체 생성자 추가

0b1875d

test: 유저 도메인 테스트 코드 작성

7720a63

larama-C self-assigned this Dec 29, 2025

larama-C added the Feature label Dec 29, 2025

Creamcheesepie approved these changes Dec 29, 2025

View reviewed changes

ys0221 reviewed Dec 29, 2025

View reviewed changes

ys0221 approved these changes Dec 29, 2025

View reviewed changes

kms152000 approved these changes Dec 29, 2025

View reviewed changes

Creamcheesepie merged commit 46d71fd into main Dec 29, 2025
2 checks passed

Creamcheesepie deleted the feat/#195 branch December 29, 2025 08:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[User] 유저 도메인 테스트 코드 작성#206

[User] 유저 도메인 테스트 코드 작성#206
Creamcheesepie merged 4 commits into
mainfrom
feat/#195

larama-C commented Dec 29, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 29, 2025

Uh oh!

github-actions Bot commented Dec 29, 2025

Uh oh!

Creamcheesepie left a comment

Uh oh!

Creamcheesepie Dec 29, 2025

Uh oh!

ys0221 Dec 29, 2025 •

edited

Loading

Uh oh!

larama-C Dec 29, 2025

Uh oh!

ys0221 left a comment

Uh oh!

kms152000 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

larama-C commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 관련 이슈

🚀 PR 개요

📌 변경 사항

🧪 테스트 방법

📸 스크린샷 (선택)

⚠️ 참고 사항

Uh oh!

github-actions Bot commented Dec 29, 2025

Test Results

Uh oh!

github-actions Bot commented Dec 29, 2025

⭐ JaCoCo Coverage

📄 Coverage Details

Uh oh!

Creamcheesepie left a comment

Choose a reason for hiding this comment

Uh oh!

Creamcheesepie Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

ys0221 Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

larama-C Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

ys0221 left a comment

Choose a reason for hiding this comment

Uh oh!

kms152000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

larama-C commented Dec 29, 2025 •

edited

Loading

ys0221 Dec 29, 2025 •

edited

Loading